Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test #6193

Closed
wants to merge 11 commits into from
Closed

test: test #6193

wants to merge 11 commits into from

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Nov 8, 2023

Reason for Change

  • #TICKET_NUMBER
  • If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review

  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see

  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Deployment Summary

@kaloster kaloster changed the title test test: test Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #6193 (5099e09) into main (6413251) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6193   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         175      175           
  Lines       14232    14232           
=======================================
  Hits        13037    13037           
  Misses       1195     1195           
Flag Coverage Δ
unittests 91.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@kaloster kaloster closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant