Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix spacing in gene expression #6214

Merged
merged 8 commits into from
Nov 13, 2023
Merged

feat: fix spacing in gene expression #6214

merged 8 commits into from
Nov 13, 2023

Conversation

joyceyan
Copy link
Contributor

@joyceyan joyceyan commented Nov 13, 2023

Reason for Change

https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-data-portal/5837

Changes

adds the proposed changes to gene expression spacing. note that as @karenliang0 notes in the ticket, the changes to shift the alignment of the cell type search bar would be in a separate ticket, so that's not in this PR.

Testing steps

static screenshot to verify pixel padding

image

easiest way to review would be to just look at the rdev: https://pr-6214-frontend.rdev.single-cell.czi.technology/gene-expression

Checklist 🛎️

TODO

  • Add product, design, and eng as reviewers for rdev review

  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see

  • For UI changes, add e2e tests to prevent regressions

i don't think e2e tests are necessary for moving stuff 4 pixels here and there

Notes for Reviewer

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b6ea61) 91.60% compared to head (4020401) 91.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6214   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         175      175           
  Lines       14232    14232           
=======================================
  Hits        13037    13037           
  Misses       1195     1195           
Flag Coverage Δ
unittests 91.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joyceyan joyceyan changed the title [wip] GE spacing feat: fix spacing in gene expression Nov 13, 2023
@joyceyan joyceyan requested review from kaloster and karenliang0 and removed request for kaloster and karenliang0 November 13, 2023 20:11
Copy link
Contributor

@kaloster kaloster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joyceyan joyceyan merged commit dde6fdf into main Nov 13, 2023
40 checks passed
@joyceyan joyceyan deleted the joyce/ge-spacing branch November 13, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants