-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix spacing in gene expression #6214
Conversation
Deployment Summary
|
04e5e13
to
5576cd8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6214 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 175 175
Lines 14232 14232
=======================================
Hits 13037 13037
Misses 1195 1195
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e792889
to
07f5cf4
Compare
5b390e6
to
4020401
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reason for Change
https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-data-portal/5837
Changes
adds the proposed changes to gene expression spacing. note that as @karenliang0 notes in the ticket, the changes to shift the alignment of the cell type search bar would be in a separate ticket, so that's not in this PR.
Testing steps
static screenshot to verify pixel padding
easiest way to review would be to just look at the rdev: https://pr-6214-frontend.rdev.single-cell.czi.technology/gene-expression
Checklist 🛎️
TODO
Add product, design, and eng as reviewers for rdev review
For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
For UI changes, add e2e tests to prevent regressions
i don't think e2e tests are necessary for moving stuff 4 pixels here and there
Notes for Reviewer