Skip to content

fix: option to test schema migration with random subset of corpus #6221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

nayib-jose-gloria
Copy link
Contributor

Reason for Change

  • Test-only bug; previous implementation to run random subset of corpus did not account for filtering out published collections with active revisions. This change moves the subsetting to only sample from the set of collections AFTER filtering out ineligible collections (published w/ active revisions)

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1e902ab) 91.60% compared to head (1872913) 91.62%.

❗ Current head 1872913 differs from pull request most recent head d27ed5a. Consider uploading reports for the commit d27ed5a to get more accurate results

Files Patch % Lines
backend/layers/processing/schema_migration.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6221      +/-   ##
==========================================
+ Coverage   91.60%   91.62%   +0.02%     
==========================================
  Files         175      175              
  Lines       14232    14228       -4     
==========================================
  Hits        13037    13037              
+ Misses       1195     1191       -4     
Flag Coverage Δ
unittests 91.62% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nayib-jose-gloria nayib-jose-gloria enabled auto-merge (squash) November 14, 2023 00:17
@nayib-jose-gloria nayib-jose-gloria merged commit 96c9631 into main Nov 14, 2023
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/fix-limit-migration branch November 14, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants