feat: clarify why marker genes are unavailable #6225
Conversation
Deployment Summary
|
joyceyan
force-pushed
the
joyce/marker-genes-unavail
branch
from
9990f13 to
6f2937d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6225 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 175 175
Lines 14207 14207
=======================================
Hits 13042 13042
Misses 1165 1165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joyceyan
force-pushed
the
joyce/marker-genes-unavail
branch
3 times, most recently
from
11e1f08 to
78b3b6f
Compare
|
LGTM! |
joyceyan
force-pushed
the
joyce/marker-genes-unavail
branch
from
6ef546c to
19ae852
Compare
| /> | ||
| </InfoButtonWrapper> | ||
| )} | ||
| {cellType && cellType.optionId === COMPARE_OPTION_ID_FOR_AGGREGATED && ( |
There was a problem hiding this comment.
here, the logic is just updated to always display the info icon button. most of the line changes are just whitespace
joyceyan
force-pushed
the
joyce/marker-genes-unavail
branch
from
3fda70a to
a5292bc
Compare
| @@ -21,7 +21,10 @@ describe("CSV download tests", () => { | |||
| }) => { | |||
| // set app state | |||
| await goToWMG(page, SHARED_LINK_NO_GROUP); | |||
| await expect(page.locator("canvas")).not.toHaveCount(0); | |||
|
|
|||
| // Loading WMG with several genes + filters set takes a bit longer to load. We need the filters | |||
There was a problem hiding this comment.
previously, these tests were taking faster to load because the blood cell types didn't have the info icon on them. since this PR adds them in, these tests appear to timeout more frequently. i tried updating the URL's to only have one gene or only one tissue type, but the tests would still timeout with the 10000ms default.
we do want WMG to load faster, but that's out of scope for this PR, so i think increasing the timeout is fine.
Reason for Change
https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-data-portal/5608
Changes
shows the info icon for all cell types, and implements the copy changes as described in the figma. there are now 3 "empty states" that we show users:
Testing steps
blood cells
cell types with < 25 cells
no marker genes at all
i also updated the
geneUtils.tstest to verify that the info icon always shows upChecklist 🛎️
Add product, design, and eng as reviewers for rdev review
For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
For UI changes, add e2e tests to prevent regressions
Notes for Reviewer