feat: remove download feature flag (#5914) #6229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment Summary
|
frano-m
commented
Nov 15, 2023
There was a problem hiding this comment.
Note, CopyMask styles are now used by EmbeddingButton component.
frano-m
commented
Nov 15, 2023
| @@ -36,9 +36,6 @@ export const CodeBlock = styled.div` | |||
| } | |||
| `; | |||
|
|
|||
| /** | |||
| * @deprecated by CodeBlock styles once "DOWNLOAD_UX" feature flag is removed. | |||
| */ | |||
| export const DownloadCodeBlock = styled.div` | |||
There was a problem hiding this comment.
Note DownloadCodeBlock styles are now used by EmbeddingButton component. I have therefore removed the @deprecated comment.
frano-m
commented
Nov 15, 2023
| const [selectedFormat, setSelectedFormat] = useState< | ||
| DATASET_ASSET_FORMAT | "" | ||
| >(""); | ||
| const [fileSize, setFileSize] = useState<number>(0); | ||
| const [fileName, setFileName] = useState<string>(""); |
There was a problem hiding this comment.
We no longer generate a cURL and therefore fileName is no longer needed.
MillenniumFalconMechanic
force-pushed
the
fran/5914-download-feature-flag
branch
from
b43c883 to
cab9002
Compare
kaloster
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
Changes
dux.