Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip failing cg unit test #6243

Merged
merged 1 commit into from
Nov 16, 2023
Merged

chore: skip failing cg unit test #6243

merged 1 commit into from
Nov 16, 2023

Conversation

atarashansky
Copy link
Contributor

@atarashansky atarashansky commented Nov 16, 2023

Reason for Change

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76c57fd) 91.79% compared to head (371a94b) 91.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6243   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files         175      175           
  Lines       14207    14207           
=======================================
  Hits        13042    13042           
  Misses       1165     1165           
Flag Coverage Δ
unittests 91.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atarashansky atarashansky merged commit ed501af into main Nov 16, 2023
@atarashansky atarashansky deleted the atar-fix-cg-unit3 branch November 16, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants