Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin no publication to the bottom of publication filter #6256

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

kaloster
Copy link
Contributor

Reason for Change

Changes

  • this code is creating a sorted version of publication_citations where any object with a name of "No Publication" is moved to the end, and the rest are sorted alphabetically by name. The sorted array is memoized, so it will only be recomputed when publication_citations changes.
Screenshot 2023-11-21 at 9 38 36 AM

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5724130) 91.79% compared to head (703ee7e) 91.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6256   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files         175      175           
  Lines       14207    14207           
=======================================
  Hits        13042    13042           
  Misses       1165     1165           
Flag Coverage Δ
unittests 91.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster requested a review from tihuan November 21, 2023 15:34
@kaloster kaloster enabled auto-merge (squash) November 21, 2023 17:51
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Love the test 🥇 Thanks so much for doing that, @kaloster !! LGTM!

@kaloster kaloster merged commit 3b8ead9 into main Nov 21, 2023
@kaloster kaloster deleted the kaloster/no-publication-updates branch November 21, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants