Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 6054 Update WMGv2 Main #6257

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Nov 21, 2023

Reason for Change

Changes

  1. Extract hooks into connect.ts
  2. Extract useScaledMeanExpression() in hooks.ts, since it's too damn long 😂
  3. Remove explicit version 2 passing to function argument. Like useCellTypesByTissueName(2) to just useCellTypesByTissueName()

Testing steps

  1. App should work as before

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7851ae1) 91.79% compared to head (97554c8) 91.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6257   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files         175      175           
  Lines       14207    14207           
=======================================
  Hits        13042    13042           
  Misses       1165     1165           
Flag Coverage Δ
unittests 91.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kaloster kaloster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor! LGTM 🚀

@tihuan tihuan enabled auto-merge (squash) November 21, 2023 18:05
@tihuan
Copy link
Contributor Author

tihuan commented Nov 21, 2023

Thanks for the quick review too! 🙌🔥

@tihuan
Copy link
Contributor Author

tihuan commented Nov 21, 2023

CC: @seve this is the refactor PR!

@tihuan tihuan merged commit 5724130 into main Nov 21, 2023
40 checks passed
@tihuan tihuan deleted the thuang-6054-refactor-wmgv2-main branch November 21, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants