Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ge style updates #6259

Merged
merged 9 commits into from
Nov 21, 2023
Merged

chore: ge style updates #6259

merged 9 commits into from
Nov 21, 2023

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Nov 21, 2023

Reason for Change

Changes

  • Change chevron color from rgb(153, 153, 153) to colors.gray[300]
  • Remove “New” tag from “Group By” (P2 since performance is so bad, maybe users will be more understanding)
  • Labels for color scale and dot size legends should be aligned with the labels for download, share, and source data.

Testing steps

  • check changes in UI

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Screenshot 2023-11-21 at 2 27 36 PM Screenshot 2023-11-21 at 2 27 31 PM Screenshot 2023-11-21 at 2 27 25 PM

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9c8015) 91.76% compared to head (720f409) 91.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6259   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         175      175           
  Lines       14129    14129           
=======================================
  Hits        12965    12965           
  Misses       1164     1164           
Flag Coverage Δ
unittests 91.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks so much, @kaloster 🙏

@kaloster kaloster enabled auto-merge (squash) November 21, 2023 21:35
@kaloster kaloster merged commit 77e0eb7 into main Nov 21, 2023
40 checks passed
@kaloster kaloster deleted the kaloster/gene-expression-updates branch November 21, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants