Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: common notification component #6269

Merged
merged 14 commits into from
Nov 28, 2023
Merged

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Nov 23, 2023

Reason for Change

Changes

Testing steps

  • Go on rdev here
  • Check that Citation is enabled on page load
  • Click Citation - notification should pop up and button should be disabled until notification is auto dismissed
  • Click Citation + Share - both notifications should pop up and stack properly
  • Share should be disabled as well until notification is auto dismissed

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Screenshot 2023-11-24 at 2 18 29 PM

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8923090) 91.76% compared to head (28d6d79) 91.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6269   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         175      175           
  Lines       14129    14129           
=======================================
  Hits        12965    12965           
  Misses       1164     1164           
Flag Coverage Δ
unittests 91.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster requested review from signechambers1, karenliang0 and a team November 24, 2023 19:53
@kaloster kaloster marked this pull request as ready for review November 24, 2023 19:54
@kaloster kaloster changed the title feat: common notification component - WIP feat: common notification component Nov 24, 2023
@signechambers1
Copy link

LGTM! Thank you Ronen!

Copy link
Contributor

@joyceyan joyceyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

this is a design nit, but the spacing here looks off? seems like the header and text should be aligned

frontend/src/components/Notification/style.ts Outdated Show resolved Hide resolved
frontend/src/components/Notification/style.ts Outdated Show resolved Hide resolved
frontend/src/components/Notification/style.ts Outdated Show resolved Hide resolved
frontend/src/components/Notification/style.ts Outdated Show resolved Hide resolved
@kaloster kaloster requested a review from joyceyan November 27, 2023 20:43
@kaloster kaloster added this pull request to the merge queue Nov 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 27, 2023
@kaloster kaloster added this pull request to the merge queue Nov 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 28, 2023
@kaloster kaloster added this pull request to the merge queue Nov 28, 2023
@kaloster kaloster removed this pull request from the merge queue due to a manual request Nov 28, 2023
@kaloster kaloster merged commit b665e78 into main Nov 28, 2023
40 checks passed
@kaloster kaloster deleted the kaloster/notifications-provider branch November 28, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants