Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tissue type filter #6279

Closed
wants to merge 1 commit into from

Conversation

MillenniumFalconMechanic
Copy link
Collaborator

@MillenniumFalconMechanic MillenniumFalconMechanic commented Nov 28, 2023

Reason for Change

Changes

  • Converted Schema 4.0.0 tissue_type to "tissue (tissue type)" format to maintain existing filter functionality.

Testing steps

  • Tested locally and in rdev.

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f520b3) 91.78% compared to head (2aeda19) 91.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6279   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files         175      175           
  Lines       14167    14167           
=======================================
  Hits        13003    13003           
  Misses       1164     1164           
Flag Coverage Δ
unittests 91.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MillenniumFalconMechanic
Copy link
Collaborator Author

Skipping iteration 1 of tissue type filter as per Slack.

@MillenniumFalconMechanic MillenniumFalconMechanic deleted the mim/6183-tissue-type-filter branch November 29, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant