Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: if preprint, fetch published doi when updating metadata #6306

Closed

Conversation

danieljhegeman
Copy link
Contributor

@danieljhegeman danieljhegeman commented Dec 4, 2023

Reason for Change

Changes

  • add logic to check if doi is a preprint, and if so, check for published doi; assign published doi if exists
  • update unit test file for crossref provider to import the correct CrossrefProvider
  • remove unused crossref provider module and remove unused preprint doi function for existing one

Testing steps

  • add unit test for published doi

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Deployment Summary

@danieljhegeman danieljhegeman marked this pull request as ready for review December 4, 2023 09:33
@danieljhegeman danieljhegeman changed the title feat: if preprint, fetch published doi when updating metadata feat: DO NOT MERGE if preprint, fetch published doi when updating metadata DO NOT MERGE Dec 4, 2023
@danieljhegeman danieljhegeman changed the title feat: DO NOT MERGE if preprint, fetch published doi when updating metadata DO NOT MERGE feat: if preprint, fetch published doi when updating metadata Dec 4, 2023
@danieljhegeman
Copy link
Contributor Author

Closing in favor of #6311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant