Skip to content

Tsmith/poetry #6331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Tsmith/poetry #6331

wants to merge 15 commits into from

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented Dec 9, 2023

Reason for Change

  • #TICKET_NUMBER
  • If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

  • use poetry to manage python dependencies
  • move all python requirements files the python_dependencies directory.
  • update dockerfiles to include the relevant python dependencies
  • add make recipe to generate requirements and requirement-dev files for each container
  • rename backend to api-server where backend is referring to api-server.
  • separate development dependencies from software dependecies.

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

@Bento007
Copy link
Contributor Author

breaking up into several smaller PRs

@Bento007 Bento007 closed this Dec 20, 2023
@Bento007 Bento007 deleted the tsmith/poetry branch December 20, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant