Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wmg): replace heatmap dots loader #6366

Merged
merged 18 commits into from
Dec 19, 2023
Merged

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Dec 18, 2023

Reason for Change

Changes

  • replaced dots loader with a single loader as per here

Testing steps

  • Go Gene Expression page - add some genes

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Screen.Recording.2023-12-19.at.11.29.23.AM.mov

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (461bd91) 91.99% compared to head (8676c04) 91.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6366   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         180      180           
  Lines       14787    14787           
=======================================
  Hits        13603    13603           
  Misses       1184     1184           
Flag Coverage Δ
unittests 91.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster requested a review from tihuan December 18, 2023 23:15
@kaloster kaloster marked this pull request as ready for review December 18, 2023 23:36
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new load state! Thanks for adding this, @kaloster 😄 🙏 !

One nit UI feedback is that the loader doesn't seem to be centered in the gray area when there are only a few genes? PTAL thank you!

Screen.Recording.2023-12-19.at.8.44.20.AM.mov

@kaloster kaloster requested a review from tihuan December 19, 2023 17:33
@kaloster kaloster enabled auto-merge (squash) December 19, 2023 19:45
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the amazing work again, @kaloster ⭐ ✨ 🙏 !!

@kaloster kaloster disabled auto-merge December 19, 2023 19:46
@kaloster kaloster enabled auto-merge (squash) December 19, 2023 21:23
@kaloster kaloster merged commit 5f4ee56 into main Dec 19, 2023
40 checks passed
@kaloster kaloster deleted the kaloster/update-heatmap-loader branch December 19, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants