-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wmg): replace heatmap dots loader #6366
Conversation
Deployment Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6366 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 180 180
Lines 14787 14787
=======================================
Hits 13603 13603
Misses 1184 1184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the new load state! Thanks for adding this, @kaloster 😄 🙏 !
One nit UI feedback is that the loader doesn't seem to be centered in the gray area when there are only a few genes? PTAL thank you!
Screen.Recording.2023-12-19.at.8.44.20.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the amazing work again, @kaloster ⭐ ✨ 🙏 !!
Reason for Change
Changes
Testing steps
Checklist 🛎️
Notes for Reviewer
Screen.Recording.2023-12-19.at.11.29.23.AM.mov