Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unescape CrossRef journal #6373

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

MillenniumFalconMechanic
Copy link
Collaborator

Reason for Change

Changes

  • Added unescape to journal value returned from CrossRef.

Testing steps

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review (see Slack).

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c7d21ed) 91.99% compared to head (4e2e9a0) 91.99%.

Files Patch % Lines
backend/layers/thirdparty/crossref_provider.py 20.00% 4 Missing ⚠️
backend/common/providers/crossref_provider.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6373   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         180      180           
  Lines       14787    14803   +16     
=======================================
+ Hits        13603    13618   +15     
- Misses       1184     1185    +1     
Flag Coverage Δ
unittests 91.99% <72.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MillenniumFalconMechanic MillenniumFalconMechanic marked this pull request as ready for review December 19, 2023 21:05
@MillenniumFalconMechanic MillenniumFalconMechanic merged commit 6892f7b into main Dec 20, 2023
39 of 40 checks passed
@MillenniumFalconMechanic MillenniumFalconMechanic deleted the mim/6268-crossref-unescape branch December 20, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants