Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update api-server to use poetry #6378

Closed
wants to merge 27 commits into from
Closed

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented Dec 20, 2023

Reason for Change

  • use poetry to manage api-server dependencies

Changes

  • separate out developer requirements from run time requirements
  • add recipe to build requirements.txt and requirements-dev.txt
  • update dockerfile.backend to install from requirements.txt and requirements-dev.txt.
  • update and freeze requirements.

Testing steps

  • testing in rdev

Checklist 🛎️

Notes for Reviewer

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2674bd) 92.44% compared to head (493ab8a) 92.42%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6378      +/-   ##
==========================================
- Coverage   92.44%   92.42%   -0.02%     
==========================================
  Files         179      179              
  Lines       14698    14702       +4     
==========================================
+ Hits        13587    13588       +1     
- Misses       1111     1114       +3     
Flag Coverage Δ
unittests 92.42% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

This PR has not seen any activity in the past 2 weeks; if nobody comments or reviews it in the next 3 days, this PR will be closed.

@github-actions github-actions bot added the stale label Jan 4, 2024
@@ -30,7 +30,7 @@ def session(self):
total=3,
backoff_factor=1,
status_forcelist=self.config.retry_status_forcelist,
method_whitelist=["POST", "HEAD", "GET", "PUT", "DELETE", "OPTIONS"],
allowed_methods=["POST", "HEAD", "GET", "PUT", "DELETE", "OPTIONS"],
Copy link
Contributor Author

@Bento007 Bento007 Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes is required because of an update with requests

@github-actions github-actions bot removed the stale label Jan 5, 2024
@Bento007
Copy link
Contributor Author

Bento007 commented Jan 5, 2024

closing in favor of #6423

@Bento007 Bento007 closed this Jan 5, 2024
@Bento007 Bento007 deleted the tsmith/api-server-poetry branch January 12, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant