fix: share link and test #6385
Merged
fix: share link and test #6385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment Summary
|
tihuan
commented
Dec 20, 2023
| @@ -218,7 +218,11 @@ function getNewSelectedFilters({ | |||
| Object.entries(tissues ?? {}).map(([id, tissue]) => [tissue.name, id]) | |||
| ); | |||
|
|
|||
| const allTissueNames = Object.keys(tissueIdsByName); | |||
There was a problem hiding this comment.
allTissueNames = Object.keys(tissueIdsByName); was returning an empty array, since Object.keys() doesn't work with Map! TIL 💡
This fixes the bug where share link tissue with tissue name won't get populated in the app state
| @@ -25,14 +25,11 @@ const tissueIds = TISSUES.map((tissue) => tissue.id); | |||
|
|
|||
| const GENES = ["DPM1", "TNMD", "TSPAN6"]; | |||
|
|
|||
| const DATASETS = [ | |||
There was a problem hiding this comment.
we've removed datasets as a filter option in the app
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6385 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 180 180
Lines 14803 14803
=======================================
Hits 13618 13618
Misses 1185 1185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tihuan
force-pushed
the
thuang-6131-enable-share-link-test
branch
from
6ce293e to
f653af4
Compare
kaloster
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
Changes
Testing steps
Checklist 🛎️
Notes for Reviewer