Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unpin tiledbsoma and census dependencies #6411

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

atarashansky
Copy link
Contributor

Reason for Change

  • #TICKET_NUMBER
  • If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Deployment Summary

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e44c58) 91.99% compared to head (2d491b1) 91.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6411   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         180      180           
  Lines       14803    14803           
=======================================
  Hits        13618    13618           
  Misses       1185     1185           
Flag Coverage Δ
unittests 91.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding the comment, @atarashansky 🙏 Really appreciate it!

@atarashansky atarashansky enabled auto-merge (squash) January 3, 2024 19:08
@atarashansky atarashansky disabled auto-merge January 4, 2024 18:50
@atarashansky atarashansky merged commit 582c9b6 into main Jan 4, 2024
10 checks passed
@atarashansky atarashansky deleted the atar-unpin-wmg-deps branch January 4, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants