Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved rollup pipeline changes #6419

Merged
merged 4 commits into from
Jan 5, 2024
Merged

feat: improved rollup pipeline changes #6419

merged 4 commits into from
Jan 5, 2024

Conversation

atarashansky
Copy link
Contributor

@atarashansky atarashansky commented Jan 4, 2024

Reason for Change

Changes

  • added a new pipeline step to generate a cell type ancestors fixture that will be used to perform the explode operation in the backend

Testing steps

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Deployment Summary

@atarashansky atarashansky changed the title feat: improved rollup feat: improved rollup pipeline changes Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f2674bd) 92.44% compared to head (f5b7289) 92.42%.

Files Patch % Lines
tests/unit/backend/wmg/fixtures/test_snapshot.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6419      +/-   ##
==========================================
- Coverage   92.44%   92.42%   -0.02%     
==========================================
  Files         179      179              
  Lines       14698    14702       +4     
==========================================
+ Hits        13587    13588       +1     
- Misses       1111     1114       +3     
Flag Coverage Δ
unittests 92.42% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atarashansky atarashansky self-assigned this Jan 4, 2024
@atarashansky atarashansky marked this pull request as ready for review January 4, 2024 22:14
Copy link
Contributor

@prathapsridharan prathapsridharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atarashansky atarashansky merged commit 9b31b6d into main Jan 5, 2024
38 of 40 checks passed
@atarashansky atarashansky deleted the atar-explode-v2 branch January 5, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants