-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable dependabot for GHA and frontend packages #6424
Conversation
Deployment Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6424 +/- ##
==========================================
- Coverage 92.51% 92.42% -0.09%
==========================================
Files 179 179
Lines 14783 14702 -81
==========================================
- Hits 13676 13588 -88
- Misses 1107 1114 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a8d580e
to
610df66
Compare
I have a few questions:
|
|
For (4), in the scenario I have in mind, the dependabot PR to update package A did not happen due to an engineer forgetting about the PR and the reaper closing that PR. So for example, package A was at version I don't know how likely this scenario is and whether it is worth agonizing over. Just want to point it out because this does seem to rely on some level of developer diligence but it might be manageable if there aren't too many PRs coming in. |
I agree it will require developer diligence for some thing. This exact scenario is why i'm in favor of switching how we manage our python dependencies to something that locks the current dependency version such a poetry. When you run If our tests cases don't break as a result then we have poor test coverage or it's a feature of the library we are not using. Either way it's something that can be addressed. Starting to use dependabot will at least get us started with keeping everything in order in a more automated way that in theory should be autopilot until a breaking changes happens. We will at least have a small version gap to cover at the point if we are making use of dependabot. |
@prathapsridharan this one should be merged before #6425 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reason for Change
Changes