Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cellguide): upload json script #6426

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Jan 8, 2024

Reason for Change

This is a script to upload cellguide descriptions using the /cellguide/v1/upload endpoint.

It requires a csv file to be present in the scripts directory with the following columns:
Cell Ontology ID, Final version (QC'd), Supporting reference 1, Supporting reference 2, Supporting reference 3, Supporting reference 4, Supporting reference 5

The script will convert the csv to json and post each row to the endpoint.

Testing steps

Step 1 - Login: python upload_cellguide_descriptions.py --deployment rdev login --api_key <api_key>
Step 2 - Upload: python upload_cellguide_descriptions.py --deployment rdev upload --path cl_descriptions.csv

Notes for Reviewer

  • rdev option is there for testing purposes - once reviewed and approved will be removed before merging.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Deployment Summary

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63cd24a) 92.07% compared to head (d100bf1) 92.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6426   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files         178      178           
  Lines       14732    14732           
=======================================
  Hits        13565    13565           
  Misses       1167     1167           
Flag Coverage Δ
unittests 92.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster marked this pull request as ready for review January 8, 2024 15:04
@kaloster kaloster requested a review from atarashansky January 8, 2024 15:07
Copy link
Contributor

@atarashansky atarashansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small question, but otherwise this looks great! I'm trusting that you've tested this in rdev already..

scripts/upload_cellguide_descriptions.py Show resolved Hide resolved
@kaloster kaloster enabled auto-merge (squash) January 10, 2024 12:30
@kaloster kaloster merged commit ef2b8c5 into main Jan 10, 2024
40 checks passed
@kaloster kaloster deleted the kaloster/upload-cellguide-descriptions branch January 10, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants