Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: SDS v20 #7000

Merged
merged 25 commits into from
May 11, 2024
Merged

chore: SDS v20 #7000

merged 25 commits into from
May 11, 2024

Conversation

atarashansky
Copy link
Contributor

Reason for Change

  • #TICKET_NUMBER
  • If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions
  • For UI changes, verify impacted analytics events still work

Notes for Reviewer

Copy link
Contributor

github-actions bot commented May 8, 2024

Deployment Summary

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (8d53d81) to head (e311a87).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7000   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         182      182           
  Lines       15522    15522           
=======================================
  Hits        14217    14217           
  Misses       1305     1305           
Flag Coverage Δ
unittests 91.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atarashansky atarashansky changed the title chore: initial pass-through to upgrade to SDS v20 chore: SDS v20 May 10, 2024
@atarashansky atarashansky requested a review from masoudmanson May 10, 2024 15:45
Copy link
Collaborator

@masoudmanson masoudmanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing all the changes, @atarashansky! it LGTM 🤩🎉🥳

frontend/src/common/theme.ts Show resolved Hide resolved
frontend/src/pages/docs/[...slug].tsx Show resolved Hide resolved
@atarashansky atarashansky merged commit c21a2d7 into main May 11, 2024
34 of 35 checks passed
@atarashansky atarashansky deleted the atar-sds-20 branch May 11, 2024 22:09
@atarashansky atarashansky restored the atar-sds-20 branch May 13, 2024 18:19
atarashansky added a commit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants