Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration bugs #7007

Merged
merged 1 commit into from
May 9, 2024
Merged

Fix migration bugs #7007

merged 1 commit into from
May 9, 2024

Conversation

masoudmanson
Copy link
Collaborator

Reason for Change

  • #TICKET_NUMBER
  • If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions
  • For UI changes, verify impacted analytics events still work

Notes for Reviewer

@masoudmanson masoudmanson requested a review from atarashansky May 9, 2024 00:04
Copy link
Contributor

github-actions bot commented May 9, 2024

Deployment Summary

@atarashansky atarashansky merged commit 6d1b61c into atar-sds-20 May 9, 2024
18 of 22 checks passed
@atarashansky atarashansky deleted the masoudmanson-sds-20 branch May 9, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants