Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accepted assays docs #7012

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

MillenniumFalconMechanic
Copy link
Collaborator

@MillenniumFalconMechanic MillenniumFalconMechanic commented May 9, 2024

Reason for Change

Changes

  • Updated docs to include link to accepted assays.

Testing steps

  • Tested locally, and on rdev.

Local SS

Screenshot 2024-05-09 at 10 43 39 AM

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review

Copy link
Contributor

github-actions bot commented May 9, 2024

Deployment Summary

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (097c0cd) to head (1dacf6b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7012   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         182      182           
  Lines       15522    15522           
=======================================
  Hits        14217    14217           
  Misses       1305     1305           
Flag Coverage Δ
unittests 91.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MillenniumFalconMechanic MillenniumFalconMechanic marked this pull request as ready for review May 9, 2024 20:55
@MillenniumFalconMechanic MillenniumFalconMechanic enabled auto-merge (squash) May 9, 2024 20:55
Copy link
Contributor

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you revert the changes to cell_type_descendants.json and tissue_descendants.json?

otherwise, doc change looks good

@MillenniumFalconMechanic MillenniumFalconMechanic force-pushed the mim/6673-docs-assay branch 3 times, most recently from 38bdfe8 to f654e40 Compare May 10, 2024 17:44
@MillenniumFalconMechanic MillenniumFalconMechanic enabled auto-merge (squash) May 10, 2024 18:17
@MillenniumFalconMechanic MillenniumFalconMechanic merged commit 8d53d81 into main May 11, 2024
35 checks passed
@MillenniumFalconMechanic MillenniumFalconMechanic deleted the mim/6673-docs-assay branch May 11, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants