Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5.1 testing #7093

Closed
wants to merge 18 commits into from
Closed

feat: 5.1 testing #7093

wants to merge 18 commits into from

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented May 23, 2024

Reason for Change

  • for testing schema migration

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • deleted contents of test bucket after merging PR. All of prod was mirrored to this rdev.

Notes for Reviewer

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (adf16e3) to head (a114eee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7093   +/-   ##
=======================================
  Coverage   92.66%   92.67%           
=======================================
  Files         188      188           
  Lines       15733    15732    -1     
=======================================
  Hits        14579    14579           
+ Misses       1154     1153    -1     
Flag Coverage Δ
unittests 92.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bento007 Bento007 changed the title feat: update requirements to use new cellxgene-schema 5.1 feat: 5.1 May 24, 2024
@Bento007 Bento007 changed the title feat: 5.1 feat: 5.1 testing May 24, 2024
@nayib-jose-gloria nayib-jose-gloria marked this pull request as ready for review May 29, 2024 13:34
@nayib-jose-gloria nayib-jose-gloria marked this pull request as draft May 29, 2024 13:34
nayib-jose-gloria and others added 7 commits May 29, 2024 13:15
# Conflicts:
#	backend/layers/processing/schema_migration.py
#	tests/unit/processing/test_spatial_assets_utils.py
# Conflicts:
#	tests/unit/processing/schema_migration/test_publish_and_cleanup.py

# temp: filter for Collections containing visium and slide-seq-v2 datasets
# TODO remove commented sectection bellow
# COLLECTIONS = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -2,12 +2,13 @@ anndata==0.8.0
awscli
boto3>=1.11.17
botocore>=1.14.17
cellxgene-schema
# install the cellxgene-schema version from latest commit on the main branch from github
git+https://github.com/chanzuckerberg/single-cell-curation.git@main#egg=cellxgene-schema&subdirectory=cellxgene_schema_cli
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@Bento007
Copy link
Contributor Author

No longer needed

@Bento007 Bento007 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants