Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) chore: split out backends #7127

Closed
wants to merge 2 commits into from
Closed

Conversation

atarashansky
Copy link
Contributor

Reason for Change

  • #TICKET_NUMBER
  • If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions
  • For UI changes, verify impacted analytics events still work

Notes for Reviewer

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 95.14563% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 92.64%. Comparing base (e00ff78) to head (9ae547b).
Report is 2 commits behind head on main.

Files Patch % Lines
backend/common/server/datadog.py 80.00% 2 Missing ⚠️
backend/common/server/config.py 98.68% 1 Missing ⚠️
backend/de/server/app.py 75.00% 1 Missing ⚠️
backend/wmg/server/app.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7127      +/-   ##
==========================================
+ Coverage   92.50%   92.64%   +0.14%     
==========================================
  Files         185      188       +3     
  Lines       15735    15710      -25     
==========================================
- Hits        14555    14554       -1     
+ Misses       1180     1156      -24     
Flag Coverage Δ
unittests 92.64% <95.14%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant