Skip to content

fix: omit orphan cells from query result (SCE-38) #7395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Dec 5, 2024

Reason for Change

Changes

  • Remove cell types from query results, where not present in ordering list

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Deployment Summary

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.90%. Comparing base (d119dac) to head (d169ae8).

Files with missing lines Patch % Lines
backend/wmg/api/v2.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7395      +/-   ##
==========================================
- Coverage   92.90%   92.90%   -0.01%     
==========================================
  Files         194      194              
  Lines       16831    16834       +3     
==========================================
+ Hits        15637    15639       +2     
- Misses       1194     1195       +1     
Flag Coverage Δ
unittests 92.90% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster closed this Dec 6, 2024
@kaloster kaloster reopened this Dec 19, 2024
@kaloster kaloster changed the title ge filter fix: omit orphan cells from query result Dec 19, 2024
@kaloster kaloster force-pushed the kaloster/ge-filter branch from 836a465 to c3379b3 Compare January 7, 2025 15:11
@kaloster kaloster changed the title fix: omit orphan cells from query result fix: omit orphan cells from query result (SCE-38) Jan 7, 2025
@kaloster kaloster marked this pull request as ready for review January 13, 2025 22:00
@kaloster kaloster requested a review from tihuan January 13, 2025 22:00
@kaloster kaloster closed this Jan 13, 2025
@kaloster kaloster reopened this Jan 14, 2025
@kaloster kaloster closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant