-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Check other endpoints for ATAC artifacts #7442
feat: Check other endpoints for ATAC artifacts #7442
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/schema-5-3 #7442 +/- ##
=====================================================
Coverage ? 92.99%
=====================================================
Files ? 196
Lines ? 16721
Branches ? 0
=====================================================
Hits ? 15550
Misses ? 1171
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things to fix
@@ -818,6 +818,8 @@ components: | |||
enum: | |||
- H5AD | |||
- RDS | |||
- FRAGMENT_TSV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We landed on using ATAC_FRAGMENT, and ATAC_INDEX
Co-authored-by: Trent Smith <1429913+Bento007@users.noreply.github.com>
Reason for Change
Changes
Notes for reviewer
In the specification doc there is some inconsistency around what the index artifact is called. I went with
FRAGMENT_INDEX
butFRAGMENT_TABIX
is also used in the spec.