Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github] Fix get_identities method not returning all identities #1118

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

jjmerchante
Copy link
Contributor

This PR fixes a bug that cause that some identities were not loaded in SortingHat and in OpenSearch were displayed as UNDEFINED.

The method get_identities was not returning the identities from reviews_data.

This commit fixes a bug that cause that some identities were not
loaded in SortingHat and in OpenSearch were displayed as UNDEFINED.

The method `get_identities` was not returning the identities from
`reviews_data`.

Signed-off-by: Jose Javier Merchante <jjmerchante@bitergia.com>
@coveralls
Copy link

coveralls commented Oct 5, 2023

Pull Request Test Coverage Report for Build 6416571174

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 85.546%

Totals Coverage Status
Change from base Build 6404879552: 0.006%
Covered Lines: 7487
Relevant Lines: 8752

💛 - Coveralls

Copy link
Member

@zhquan zhquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhquan zhquan closed this in e09e5b3 Oct 5, 2023
@zhquan zhquan merged commit e09e5b3 into chaoss:master Oct 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants