Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the backend name for SortingHat identities #1124

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

jjmerchante
Copy link
Contributor

This PR allows to change the backend name for SortingHat identities. The GitHub2 backend is updated from 'github2' to 'github'. This way GitHub2 and GitHub share the same identity in SortingHat.

This change could break existing dashboards because the new github comments ids will be different from the old ones.

@coveralls
Copy link

coveralls commented Oct 18, 2023

Pull Request Test Coverage Report for Build 6560840523

  • 7 of 8 (87.5%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 85.539%

Changes Missing Coverage Covered Lines Changed/Added Lines %
grimoire_elk/elk.py 1 2 50.0%
Totals Coverage Status
Change from base Build 6510219185: -0.01%
Covered Lines: 7459
Relevant Lines: 8720

💛 - Coveralls

This commits allows to define the name of the backend for
the identities stored in SortingHat. GitHub2 backend is
updated from 'github2' to 'github' in order to have the
same uuid in sortinghat.

Signed-off-by: Jose Javier Merchante <jjmerchante@bitergia.com>
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit cfe6ce1 into chaoss:master Oct 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants