Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Incorrect date type in identity enrollment retrieval #1134

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[bug] Incorrect date type in identity enrollment retrieval #1134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions grimoire_elk/enriched/jira.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,10 @@ def get_item_sh(self, item, roles=None, date_field=None):
if not self.sortinghat:
return eitem_sh

created = str_to_datetime(date_field)

for rol in roles:
identity = self.get_sh_identity(item, rol)

eitem_sh.update(self.get_item_sh_fields(identity, created, rol=rol))
eitem_sh.update(self.get_item_sh_fields(identity, date_field, rol=rol))

if not eitem_sh[rol + '_org_name']:
eitem_sh[rol + '_org_name'] = SH_UNKNOWN_VALUE
Expand Down
2 changes: 1 addition & 1 deletion grimoire_elk/enriched/mediawiki.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def get_review_sh(self, revision, item):
""" Add sorting hat enrichment fields for the author of the revision """

identity = self.get_sh_identity(revision)
update = str_to_datetime(item[self.get_field_date()])
update = item[self.get_field_date()]
erevision = self.get_item_sh_fields(identity, update)

return erevision
Expand Down
2 changes: 1 addition & 1 deletion grimoire_elk/enriched/meetup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ def get_item_sh(self, item):
else:
return sh_fields

created = unixtime_to_datetime(item['created'] / 1000)
created = unixtime_to_datetime(item['created'] / 1000).isoformat()
if self.sortinghat:
sh_fields = self.get_item_sh_fields(identity, created)
else:
Expand Down
8 changes: 8 additions & 0 deletions releases/unreleased/bug-on-some-backends-enrichment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
title: Bug on some backends enrichment
category: fixed
author: Jose Javier Merchante <jjmerchante@bitergia.com>
issue: null
notes: >
Mediawiki, Meetup are Jira were failing to retrieve
the enrollment for an identity.
Loading