Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enrich] Avoid "-- UNDEFINED --" values #1165

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

zhquan
Copy link
Member

@zhquan zhquan commented Aug 29, 2024

Avoid -- UNDEFINED -- values for all SortingHat fields when
Mordred loses connection to the SortingHat server during the
enrichment or autorefresh execution. It will keep the values
​of the name, email, id and uuid fields.

@zhquan zhquan force-pushed the avoid_undefined branch 2 times, most recently from 21aec73 to 8fa2bc8 Compare August 29, 2024 16:12
@zhquan zhquan requested a review from jjmerchante August 29, 2024 16:13
Copy link
Contributor

@jjmerchante jjmerchante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM It works as expected, Just one change.

grimoire_elk/enriched/enrich.py Outdated Show resolved Hide resolved
Avoid `-- UNDEFINED --` values for all SortingHat fields when
Mordred loses connection to the SortingHat server during the
enrichment or autorefresh execution. It will keep the values
of the `name`, `email`, `id` and `uuid` fields.

Signed-off-by: Quan Zhou <quan@bitergia.com>
@jjmerchante jjmerchante merged commit 349d594 into chaoss:master Sep 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants