Switch around BaseError.message and msg #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating error messages when attempting to build this, the non-interplotated messages were leaking into the API. Further more, message being non-interplotated, and msg being interplotated felt backwards to me, so I've switched them around, and I've also hidden msg to _msg to make it a little clear that it's an internal detail only. Signed-off-by: Steve Kowalik <steven@wedontsleep.org>
s-t-e-v-e-n-k
force-pushed
the
switch-exception-message-around
branch
from
d4616a1
to
4a56d72
Compare
|
Merged. @s-t-e-v-e-n-k thanks a lot for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating error messages when attempting to build this, the non-interplotated messages were leaking into the API. Further more, message being non-interplotated, and msg being interplotated felt backwards to me, so I've switched them around, and I've also hidden msg to _msg to make it a little clear that it's an internal detail only.