Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete scheduled tasks with no job due to Redis connection error #810

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

evamillan
Copy link
Contributor

This PR adds an API function to create scheduled tasks and fixes the issue with the tasks that have no enqueued job due to a Redis connection error when they are created.

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments

sortinghat/core/jobs.py Outdated Show resolved Hide resolved
releases/unreleased/delete-task-on-error.yml Show resolved Hide resolved
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas
Copy link
Member

sduenas commented Aug 29, 2023

@evamillan I messed it up with your branch updating it. Can you revert the changes, please?

Adds the 'add_scheduled_task' API function.

Signed-off-by: Eva Millán <evamillan@bitergia.com>
Removes the newly created ScheduledTask from the database if
the job could not be enqueued due to a Redis connection error.

Signed-off-by: Eva Millán <evamillan@bitergia.com>
@sduenas sduenas merged commit ab04027 into chaoss:master Aug 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants