Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jobs missing from results #908

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

jjmerchante
Copy link
Contributor

This PR fixes a bug that caused an empty list of job results when one of them was missing in Redis. This PR also updates the time the job results are kept to one week.

This also updates the worker entry point to receive parameters when a container runs.

Updates the docker image for the SortingHat worker,
so it can receive parameters when a container runs.
This is needed to set from which queues a worker will
listen too.

Signed-off-by: Jose Javier Merchante <jjmerchante@bitergia.com>
Fetching the job list failed when job data was missing in Redis.
This update discards missing results and deletes the missing job
entries from the registry, ensuring the job listing works correctly.

Signed-off-by: Jose Javier Merchante <jjmerchante@bitergia.com>
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 is giving some errors. Can you fix them?

This commit updates the retention period for job results
in SortingHat to one week.

Signed-off-by: Jose Javier Merchante <jjmerchante@bitergia.com>
@sduenas sduenas merged commit 51f29eb into chaoss:master Aug 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants