Close DB connection before job completion #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
requested changes
Aug 30, 2024
jjmerchante
force-pushed
the
fix-sql-warning
branch
6 times, most recently
from
2548048
to
692c13c
Compare
RQ workers create a fork to run the function. The issue arises when, after completing the job, the MariaDB logs display the warning: `Aborted connection to db. Got an error reading communication packets`. This change ensures the database connection is closed before the fork ends, preventing the warning from appearing. Signed-off-by: Jose Javier Merchante <jjmerchante@bitergia.com>
jjmerchante
force-pushed
the
fix-sql-warning
branch
from
692c13c
to
4142ab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RQ workers create a fork to run the function. The issue arises when, after completing the job, the MariaDB logs display the warning:
Aborted connection to db. Got an error reading communication packets. This change ensures the database connection is closed before the fork ends, preventing the warning from appearing.