Merged
Conversation
evamillan
force-pushed
the
skip-recommendation
branch
2 times, most recently
from
dec31e1 to
044bd51
Compare
sduenas
requested changes
Nov 21, 2024
Member
sduenas
left a comment
sduenas
left a comment
There was a problem hiding this comment.
The PR looks ok but when there's only one recommendation or it's the last recommendation, the Skip button doesn't show. In those cases, the button should be there but once is clicked, the modal hides.
evamillan
force-pushed
the
skip-recommendation
branch
from
044bd51 to
03cb585
Compare
Adds a button on the Review recommendations modal to skip the current recommendation and load the next one. Signed-off-by: Eva Millán <evamillan@bitergia.com>
sduenas
force-pushed
the
skip-recommendation
branch
from
03cb585 to
4570a03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a button on the "Review recommendations" modal to skip the current recommendation and load the next one.
Fixes #937.