Skip to content

security validation for uri parameter - part 2 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bunglegrind wants to merge 1 commit into
base: master
Choose a base branch
from
Open

security validation for uri parameter - part 2 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions routes/users.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ app.post('/add', function(req, res, next){
// SHOW EDIT USER FORM
app.get('/edit/(:id)', function(req, res, next){
req.getConnection(function(error, conn) {
conn.query('SELECT * FROM users WHERE id = ' + req.params.id, function(err, rows, fields) {
conn.query('SELECT * FROM users WHERE id = ?', req.params.id, function(err, rows, fields) {
if(err) throw err

// if user not found
Expand Down Expand Up @@ -158,7 +158,7 @@ app.put('/edit/(:id)', function(req, res, next) {
}

req.getConnection(function(error, conn) {
conn.query('UPDATE users SET ? WHERE id = ' + req.params.id, user, function(err, result) {
conn.query('UPDATE users SET ? WHERE id = ?', [user, req.params.id], function(err, result) {
//if(err) throw err
if (err) {
req.flash('error', err)
Expand Down Expand Up @@ -212,7 +212,7 @@ app.delete('/delete/(:id)', function(req, res, next) {
var user = { id: req.params.id }

req.getConnection(function(error, conn) {
conn.query('DELETE FROM users WHERE id = ' + req.params.id, user, function(err, result) {
conn.query('DELETE FROM users WHERE id = ?', req.params.id, function(err, result) {
//if(err) throw err
if (err) {
req.flash('error', err)
Expand Down