Fix dyno resolving dependently-typed fields in method #25932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riftEmber
force-pushed
the
resolve-dependent-type-field
branch
from
5d9f013
to
75b1fa7
Compare
riftEmber
changed the title
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
riftEmber
force-pushed
the
resolve-dependent-type-field
branch
from
75b1fa7
to
7c5551b
Compare
2 tasks
Signed-off-by: Anna Rift <anna.rift@hpe.com>
riftEmber
force-pushed
the
resolve-dependent-type-field
branch
from
baba4e2
to
0326e9e
Compare
10 tasks
dlongnecke-cray
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable dyno to type resolve usages of dependently-typed class fields, used within methods.
This wasn't working due to the method receiver type being left generic during instantiation. Fixed by using the actual
BasicClassTypeto instantiate the formal when it's generic.Resolves https://github.com/Cray/chapel-private/issues/6690.
[reviewer info placeholder]
Testing: