Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify convert-uast's handling of SymExprs and similar #25946

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Simplify convert-uast's handling of SymExprs and similar #25946

merged 10 commits into from
Sep 24, 2024

Commits on Sep 24, 2024

  1. Working towards fixups for types 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7524785 View commit details
    Browse the repository at this point in the history

  2. Prototype 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8e89f9f View commit details
    Browse the repository at this point in the history

  3. Rearrange code to make the diffs cleaner 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9d3035a View commit details
    Browse the repository at this point in the history

  4. Simplify type fixups & get it compiling 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c818217 View commit details
    Browse the repository at this point in the history

  5. Save converted types in a map 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a534dd5 View commit details
    Browse the repository at this point in the history

  6. Remove ConvertedSymbolsMap in favor of one level 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    818b7d3 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary changes 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    494f65d View commit details
    Browse the repository at this point in the history

  8. Fix TemporaryConversionSymbol / TemporaryConversionType ctors 

    Need to use 'explicit' since implicit conversion not needed here.

---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8a49ddd View commit details
    Browse the repository at this point in the history

  9. Use INT_FATAL for "could not find target" errors 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c57204a View commit details
    Browse the repository at this point in the history

  10. convertFilterModuleIds -> modulesToConvert, use unordered_set 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9bb63b3 View commit details
    Browse the repository at this point in the history