fix: enforce path !empty check no matter file/dir allow states #801
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR corrects didSelectFile()'s logical precendence. Currently,
m.Path
's nil check is included in the truth value ofisDir && m.DirAllowed
rather than being a separate truth value. This is due to Go considering logical AND to have a higher precedence than logical OR (source).Related issue/discussion: N/A
Tests/Steps To Reproduce
You can recreate this issue without any Bubble Tea infrastructure. Here is a trivial example:
Will result in:
Checklist before requesting a review
CONTRIBUTING.md