Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/test.sh: Fixes broken table example #685

Closed
wants to merge 1 commit into from

Conversation

hxlnt
Copy link

@hxlnt hxlnt commented Oct 8, 2024

Fixes broken portion of examples/test.sh due to incorrect path to CSV. Also adds a --height=12 to work around current bug where height is set to 0 if not specified.

caarlos0 added a commit that referenced this pull request Nov 15, 2024
@caarlos0
Copy link
Member

this is actually a bug in the table component, fixed in #716

thanks for the PR though 🙏🏻

@hxlnt
Copy link
Author

hxlnt commented Nov 18, 2024

The linked PR doesn't appear to fix the CSV link. (Added for clarity: The added "../" brings the CSV path up a level.)

@caarlos0
Copy link
Member

ah, right!

caarlos0 added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants