Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: removing huh as a dep #742

Merged
merged 35 commits into from
Dec 9, 2024
Merged

refactor: removing huh as a dep #742

merged 35 commits into from
Dec 9, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 5, 2024

fixes #741

@caarlos0
Revert "feat: huh gum write (#525)"
ce78569 
This reverts commit 4d5d531.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
Revert "Use Huh for Gum Confirm (#522)"
6c458ea 
This reverts commit f7572e3.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
revert: Use Huh for Gum Choose (#521)
072d1c1 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
revert: feat: huh for gum input (#524)
5223cc3
@caarlos0
revert: feat: huh file picker (#523)
5a1d93f
@caarlos0
feat: remove huh
7d50339
@caarlos0
fix: timeouts
bd3638f
@caarlos0
fix: lint issues
9cb978f
@caarlos0 caarlos0 self-assigned this Dec 5, 2024
@caarlos0 caarlos0 marked this pull request as ready for review December 5, 2024 13:57
aymanbagabas
aymanbagabas approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yass!! 🙌

meowgorithm
meowgorithm approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@meowgorithm meowgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BEAST!

caarlos0
caarlos0 commented Dec 6, 2024
View reviewed changes
confirm/confirm.go Outdated Show resolved Hide resolved
@caarlos0 caarlos0 merged commit e30fc5e into main Dec 9, 2024
14 checks passed
@caarlos0 caarlos0 deleted the huh-rev branch December 9, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm meowgorithm approved these changes

@aymanbagabas aymanbagabas aymanbagabas approved these changes

Assignees

@caarlos0 caarlos0

Labels
cmd/choose cmd/confirm cmd/file cmd/input cmd/write enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: remove huh as a dependency
3 participants
@caarlos0 @meowgorithm @aymanbagabas