Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pager): use help bubble #748

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix(pager): use help bubble #748

merged 1 commit into from
Dec 9, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 6, 2024

use the help bubble in the pager component

@caarlos0 caarlos0 added enhancement New feature or request cmd/pager labels Dec 6, 2024
@caarlos0 caarlos0 marked this pull request as ready for review December 6, 2024 19:49
@caarlos0 caarlos0 self-assigned this Dec 6, 2024
@caarlos0 caarlos0 force-pushed the interrupt branch 2 times, most recently from 778aeea to 7c65e38 Compare December 9, 2024 17:17
Base automatically changed from interrupt to main December 9, 2024 17:30
bashbunni
bashbunni approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@bashbunni bashbunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before:
image

after:
image

@bashbunni
Copy link
Member

didn't look at why lint is failing though 🤔

@caarlos0 caarlos0 merged commit 2e2b020 into main Dec 9, 2024
14 checks passed
@caarlos0 caarlos0 deleted the pager-help branch December 9, 2024 18:05
@caarlos0
Copy link
Member Author

caarlos0 commented Dec 9, 2024

didn't look at why lint is failing though 🤔

was fixed in previous PRs I think

@caarlos0
Copy link
Member Author

caarlos0 commented Dec 9, 2024

before: image

after: image

yup, only change was to make the help lowercase, so it matches with the other components as well

@bashbunni bashbunni added this to the v0.15.0 milestone Jan 12, 2025
@BrewTestBot BrewTestBot mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbunni bashbunni bashbunni approved these changes

@aymanbagabas aymanbagabas aymanbagabas approved these changes

Assignees

@caarlos0 caarlos0

Labels
cmd/pager enhancement New feature or request
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@caarlos0 @bashbunni @aymanbagabas