Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --no-strip-ansi #784

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: --no-strip-ansi #784

merged 1 commit into from
Dec 17, 2024

Conversation

caarlos0
Copy link
Member

I think this would be mostly useful for choose and filter, but anyway, this allows to disable the ANSI stripping when reading from STDIN.

alternative implementation of #782

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Dec 17, 2024
@caarlos0 caarlos0 self-assigned this Dec 17, 2024
@caarlos0 caarlos0 merged commit 4cedf9f into main Dec 17, 2024
14 checks passed
@caarlos0 caarlos0 deleted the optionally-strip-ansi branch December 17, 2024 16:56
@srithon
Copy link
Contributor

srithon commented Dec 18, 2024

Hey @caarlos0, I mentioned this briefly on #782, but I think fully implementing this feature will require a bit more work; I went into more detail in issue #785.

@caarlos0
Copy link
Member Author

for the specific cases of the styling, yes, it might need more work, currently i would classify it as 'least effort' - if you strip ansi, it might work (if its just color changes for example), if its more complex things, it probably won't.

can you share some specific case in which you found problems?

@srithon
Copy link
Contributor

srithon commented Dec 24, 2024

for the specific cases of the styling, yes, it might need more work, currently i would classify it as 'least effort' - if you strip ansi, it might work (if its just color changes for example), if its more complex things, it probably won't.

can you share some specific case in which you found problems?

Sorry for the late reply, but I gave an example in issue #785. I could try to help resolve the issue, but unfortunately I'm not sure where to start with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants