Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spin): clear title after finished #815

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix(spin): clear title after finished #815

merged 1 commit into from
Jan 22, 2025

Conversation

caarlos0
Copy link
Member

closes #802

@caarlos0
fix(spin): clear title after finished
9127b5b 
closes #802

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Jan 21, 2025
@caarlos0 caarlos0 requested a review from a team as a code owner January 21, 2025 19:32
@caarlos0 caarlos0 requested review from csandeep and removed request for a team January 21, 2025 19:32
@ccoVeille
Copy link
Contributor

I was about to say "OK but can't you cover it with a test"

Then I realized this project has barely no test.

I'm surprised by this, so I opened

ccoVeille
ccoVeille approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except there are no tests to cover this.

Let's say OK

@caarlos0 caarlos0 merged commit 2da9527 into main Jan 22, 2025
14 checks passed
@caarlos0 caarlos0 deleted the 802 branch January 22, 2025 14:17
@bashbunni bashbunni added this to the v0.15.1 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm meowgorithm approved these changes

@aymanbagabas aymanbagabas aymanbagabas approved these changes

@ccoVeille ccoVeille ccoVeille approved these changes

@csandeep csandeep Awaiting requested review from csandeep csandeep is a code owner automatically assigned from charmbracelet/everyone

Assignees

@caarlos0 caarlos0

Labels
None yet
Projects
None yet
Milestone
v0.15.1
Development

Successfully merging this pull request may close these issues.

gum --title persists after spin cmd completed
5 participants
@caarlos0 @ccoVeille @meowgorithm @aymanbagabas @bashbunni