Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(choose): order when using --label-delimiter #867

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix(choose): order when using --label-delimiter #867

merged 1 commit into from
Mar 6, 2025

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Mar 5, 2025

closes #829

@caarlos0 caarlos0 self-assigned this Mar 5, 2025
@caarlos0 caarlos0 requested a review from a team as a code owner March 5, 2025 13:47
@caarlos0 caarlos0 requested review from raphamorim and removed request for a team March 5, 2025 13:47
@caarlos0 caarlos0 added the bug Something isn't working label Mar 5, 2025
@caarlos0 caarlos0 mentioned this pull request Mar 5, 2025
Closed
@gortloveslinux
Copy link

Thanks, my MR wasn't configured correctly so GitHub said it couldn't merge. I removed it so I could reissue it, but my week got busy. Glad it'll get in!

@caarlos0 caarlos0 merged commit 204d219 into main Mar 6, 2025
14 checks passed
@caarlos0 caarlos0 deleted the choose-labels-order branch March 6, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas aymanbagabas approved these changes

@raphamorim raphamorim raphamorim approved these changes

@andreynering andreynering andreynering approved these changes

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gum choose sometimes looses ordering when using --label-delimiter
5 participants
@caarlos0 @gortloveslinux @aymanbagabas @raphamorim @andreynering