Skip to content

Commit

Permalink
Prefer apt-get vs apt for Debian docker image
Browse files Browse the repository at this point in the history
As recommended by Hadolint.
  • Loading branch information
spotlightishere committed Jan 3, 2025
1 parent 6b9a6a8 commit a23a0de
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions distribution/charted/docker/debian.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
FROM rustlang/rust:nightly-bookworm-slim AS build

ENV DEBIAN_FRONTEND=noninteractive
RUN apt update && \
apt upgrade -y && \
apt install -y --no-install-recommends \
RUN apt-get update && \

Check failure on line 20 in distribution/charted/docker/debian.Dockerfile

View workflow job for this annotation

GitHub Actions / Hadolint [./distribution/charted/docker/debian.Dockerfile]

DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
apt-get upgrade -y && \
apt-get install -y --no-install-recommends \
git \
mold \
ca-certificates \
Expand All @@ -40,7 +40,7 @@ RUN cargo build --locked --release --package charted --features bundled-sqlite -
##### FINAL STAGE
FROM debian:bookworm-slim

RUN apt update && apt upgrade -y && apt install -y bash tini curl libssl-dev
RUN apt-get update && apt-get upgrade -y && apt-get install -y bash tini curl libssl-dev

Check failure on line 43 in distribution/charted/docker/debian.Dockerfile

View workflow job for this annotation

GitHub Actions / Hadolint [./distribution/charted/docker/debian.Dockerfile]

DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`

Check failure on line 43 in distribution/charted/docker/debian.Dockerfile

View workflow job for this annotation

GitHub Actions / Hadolint [./distribution/charted/docker/debian.Dockerfile]

DL3015 info: Avoid additional packages by specifying `--no-install-recommends`

Check failure on line 43 in distribution/charted/docker/debian.Dockerfile

View workflow job for this annotation

GitHub Actions / Hadolint [./distribution/charted/docker/debian.Dockerfile]

DL3009 info: Delete the apt-get lists after installing something

WORKDIR /app/noelware/charted/server

Expand Down

0 comments on commit a23a0de

Please sign in to comment.