Upgrade faraday gem to v1.x [ch20108] (#81)

chartmogul · Aug 11, 2020 · e3f1c43 · e3f1c43
1 parent 6863c9d
commit e3f1c43
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/chartmogul-ruby.gemspec b/chartmogul-ruby.gemspec
@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
   spec.executables           = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths         = ['lib']
 
-  spec.add_dependency 'faraday', '~> 0.17.3'
+  spec.add_dependency 'faraday', '~> 1.0.0'
 
   spec.add_development_dependency 'bundler', '~> 2'
   spec.add_development_dependency 'pry', '~> 0.12.2'

diff --git a/lib/chartmogul/api_resource.rb b/lib/chartmogul/api_resource.rb
@@ -37,7 +37,7 @@ def self.connection
 
     def self.handling_errors
       yield
-    rescue Faraday::ClientError => e
+    rescue Faraday::ClientError, Faraday::ServerError => e
       e.response ? handle_request_error(e) : handle_other_error(e)
     rescue StandardError => e
       handle_other_error(e)
@@ -86,7 +86,7 @@ def self.build_connection
         faraday.request :retry, max: ChartMogul.max_retries, retry_statuses: RETRY_STATUSES,
                                 max_interval: MAX_INTERVAL, backoff_factor: BACKOFF_FACTOR,
                                 interval_randomness: INTERVAL_RANDOMNESS, interval: INTERVAL, exceptions: RETRY_EXCEPTIONS
-        faraday.use Faraday::Adapter::NetHttp
+        faraday.adapter Faraday::Adapter::NetHttp
       end
     end
   end