-
Notifications
You must be signed in to change notification settings - Fork 2
[feat] 상대방 프로필 조회 API 구현 #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shinwokkang
wants to merge
32
commits into
main
Choose a base branch
from
feat/148-other-profile-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,205
−1,127
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2303149
feat : APIResponse 하나 정의
8335098
feat : 모임생성페이지 주소
2e0b84f
chore : 모임생성 type 정의
d2f45cb
feat : 모임생성페이지 API 연동
e5dd1d8
fix : s3에서 주는 그림을 쓰려면 이렇게 해야한다고 한다.
57ddc1a
chore : 더미데이터 제거
e4c38eb
feat : 검색페이지 API 연결
6eb7efb
feat : API 연결 + 연결에 따른 UI수정
f4f6348
fix : create페이지 수정
8e6bf10
chore : type error
4b3d938
feat: implement book story like API and integrate into main pages
shinwokkang 13c5c98
feat: refine book story like detail, navigation and UI
shinwokkang 68fca5b
feat: implement member subscription (follow/unfollow) API and integra…
shinwokkang 7615276
feat: 좋아요 및 구독 API 구현
shinwokkang d6d27fd
fix : 사진부분 수정
40d450c
Merge branch 'dev' into feat-108-group-api
hongik-luke 1e43d6b
Merge pull request #140 from checkmo2025/feat-108-group-api
hongik-luke f2087c3
fix : build 오류 해결
cf28319
style : 내 모임쪽 스크롤 안생기게끔 수정
6f250c0
Merge pull request #144 from checkmo2025/142-fixs/tyle
hongik-luke 02e9e82
refactor: apply code review feedbacks
shinwokkang cf1ff80
fix: optimistically update comment count in story lists
shinwokkang 25b3d26
feat: add routing to other profile from book story cards
shinwokkang 5314381
feat: implement other profile api and display dynamic info
shinwokkang d5f04e2
fix: remove undefined follow mutation and fix lint
shinwokkang 23165de
Merge pull request #137 from checkmo2025/feat/136-like-subscribe-api
shinwokkang fd8ca73
fix: resolve conflicts and restore toggle follow mutation
shinwokkang 8ffeccb
style: match following button layout width to primary button
shinwokkang cf5b7cb
fix: resolve scoping error and adjust following button theme
shinwokkang de50874
style: apply Subbrown_4 background and primary-3 text color for follo…
shinwokkang 0bbffe8
feat: 상대방 프로필 조회 API 구현
shinwokkang 8644e86
fix: apply optimistic update for other member story likes and comments
shinwokkang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebKit scrollbar rule should be inside the
@utilityblock.The
-ms-overflow-styleandscrollbar-widthproperties are inside@utility no-scrollbar, but the::-webkit-scrollbarpseudo-element rule (lines 183-185) is defined as a separate class selector outside the utility. This inconsistency may cause the WebKit rule to not apply correctly when using the utility class.🔧 Proposed fix to consolidate the rules
`@utility` no-scrollbar { -ms-overflow-style: none; /* IE/Edge */ scrollbar-width: none; /* Firefox */ + &::-webkit-scrollbar { + display: none; + } } -.no-scrollbar::-webkit-scrollbar { - display: none; -}Note: The static analysis errors about
@utilityare false positives—this is valid Tailwind CSS v4 syntax, which the linters aren't configured to recognize.📝 Committable suggestion
🧰 Tools
🪛 Biome (2.4.4)
[error] 179-182: Tailwind-specific syntax is disabled.
(parse)
🪛 Stylelint (17.3.0)
[error] 179-179: Unexpected unknown at-rule "@Utility" (scss/at-rule-no-unknown)
(scss/at-rule-no-unknown)
🤖 Prompt for AI Agents